RFR (trivial): 8003632 HPROF class file version java.lang.RuntimeException errors (original) (raw)
Mandy Chung mandy.chung at oracle.com
Fri Dec 14 02:03:59 UTC 2012
- Previous message: RFR (trivial): 8003632 HPROF class file version java.lang.RuntimeException errors
- Next message: RFR (trivial): 8003632 HPROF class file version java.lang.RuntimeException errors
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good to me.
I didn't know about this file and so I was interested in finding out more. This file classfile_constants.h doesn't look like a header file exported from the hotspot repo (I couldn't find it). It's used by hprof and the old verifier (jdk/src/share/native/common/check_code.h). This is probably a good candidate for future clean up so that we don't need to remember to fix this header file when we bump the classfile version number every time if feasible. Anyway, David - your fix is good to go.
Mandy
On 12/13/2012 3:30 PM, David Holmes wrote:
Trivial update of max classfile version to 52.
http://cr.openjdk.java.net/~dholmes/8003632/webrev/ Pushing through tl/jdk Thanks, David
- Previous message: RFR (trivial): 8003632 HPROF class file version java.lang.RuntimeException errors
- Next message: RFR (trivial): 8003632 HPROF class file version java.lang.RuntimeException errors
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]