RFR (trivial): 8003632 HPROF class file version java.lang.RuntimeException errors (original) (raw)

Kelly O'Hair kelly.ohair at oracle.com
Fri Dec 14 02:54:53 UTC 2012

This file was added by me, to the jdk repo, mostly for reading class files. But as I recall (it was a while ago) the idea was that this file would describe the classfile format for the jdk being released.

As I recall, the hotspot sources never exported anything like this, certainly not something that could be used in C code.

-kto

On Dec 13, 2012, at 6:27 PM, David Holmes wrote:

On 14/12/2012 12:03 PM, Mandy Chung wrote:

Looks good to me. Thanks Mandy. FYI tested with nsk/hprof suite

I didn't know about this file and so I was interested in finding out more. This file classfileconstants.h doesn't look like a header file exported from the hotspot repo (I couldn't find it). It's used by hprof and the old verifier (jdk/src/share/native/common/checkcode.h). This is probably a good candidate for future clean up so that we don't need to remember to fix this header file when we bump the classfile version number every time if feasible. Anyway, David - your fix is good to go. Yes definitely a candidate for clean up. FYI this was added here under: 6855180: Fix classfile version check in javacrwdemo Previously the version number was hard-wired into jdk/src/share/demo/jvmti/javacrwdemo/javacrwdemo.c Cheers, David Mandy

On 12/13/2012 3:30 PM, David Holmes wrote: Trivial update of max classfile version to 52.

http://cr.openjdk.java.net/~dholmes/8003632/webrev/ Pushing through tl/jdk Thanks, David

More information about the core-libs-dev mailing list