RFR: javax.xml.stream: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader) (original) (raw)

Joe Wang huizhe.wang at oracle.com
Tue Dec 18 17:29:58 UTC 2012

Hi Daniel,

The call: T provider = findServiceProvider(type) in static T find(Class type, String factoryId, ClassLoader cl, String fallbackClassName) ignored factoryId, and assumed it's the same as type.getName(). I looked back I had the same bug in my original patch.

-Joe

On 12/18/2012 8:39 AM, Daniel Fuchs wrote:

Hi,

Thanks for the review. I updated the webrev to keep track of your suggested change. <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.stream/webrev.01/>

-- daniel On 12/18/12 4:00 PM, Alan Bateman wrote:

I looked through this installment and aside from an aside from an alignment issue at lines 101-102 in XMLEventFactory.java then it looks good to me. Also thank you again for being so careful as you work through each of these areas. -Alan

More information about the core-libs-dev mailing list