RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader) (original) (raw)

Joe Wang huizhe.wang at oracle.com
Tue Dec 18 18:38:45 UTC 2012

Hi Daniel,

Looks great! I see you've added many verifications.

One minor note, creationMethod is used in place of the object instance for the creationMethod.invoke call, although it's ignored for a static method anyways. Is there a reason for doing that?

-Joe

On 12/18/2012 8:42 AM, Daniel Fuchs wrote:

Hi,

Here is a new webrev in the series that addresses using ServiceLoader in JAXP for JDK 8. 7169894: JAXP Plugability Layer: using service loader This changeset addresses modification in the javax.xml.transform package. It is similar to changes proposed for the javax.xml.parsers package [1], with only a few differences due to the specificity of javax.xml.transform.

<http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.transform/webrev.00/> best regards, -- daniel previous webrevs in the series: [1] javax.xml.parsers: <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.parsers/webrev.06/> [2] javax.xml.datatype: <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.datatype/webrev.02/> [3] javax.xml.stream <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.stream/webrev.01/>

More information about the core-libs-dev mailing list