JDK 8 code review request for 8005042 Add Method.isDefault to core reflection (original) (raw)
Mike Duigou mike.duigou at oracle.com
Tue Dec 18 21:17:33 UTC 2012
- Previous message: JDK 8 code review request for 8005042 Add Method.isDefault to core reflection
- Next message: JDK 8 code review request for 8005042 Add Method.isDefault to core reflection
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good to me. Will a JLS reference be added in when defined? It seems kind of odd to mention JLS and not provide a ref.
Nice use of annotations in the test. I will steal this technique and can think of tests where I should have used it.
Mike
On Dec 18 2012, at 12:43 , Joe Darcy wrote:
Hello,
Please review these changes to add core reflection support to recognize default methods: 8005042 Add Method.isDefault to core reflection http://cr.openjdk.java.net/~darcy/8005042.0/ Thanks, -Joe
- Previous message: JDK 8 code review request for 8005042 Add Method.isDefault to core reflection
- Next message: JDK 8 code review request for 8005042 Add Method.isDefault to core reflection
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]