JDK 8 code review request for 8005042 Add Method.isDefault to core reflection (original) (raw)

Jim Gish jim.gish at oracle.com
Tue Dec 18 21:20:24 UTC 2012

Code looks good, Joe. There is just one grammatical nit with the comment:

* A default method is a non-abstract method, that is a method with

512 * a body, declared in an interface type.

"that is" should have a comment after it.

Thanks, Jim

On 12/18/2012 03:43 PM, Joe Darcy wrote: > Hello, >> Please review these changes to add core reflection support to > recognize default methods: >> 8005042 Add Method.isDefault to core reflection > http://cr.openjdk.java.net/~darcy/8005042.0/ >> Thanks, >> -Joe >

Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304 Oracle Java Platform Group | Core Libraries Team 35 Network Drive Burlington, MA 01803 jim.gish at oracle.com

More information about the core-libs-dev mailing list