RFR: (jaxp) 8003261 : static field is public but not final (original) (raw)

Lance Andersen Lance.Andersen at oracle.com
Wed Dec 19 02:16:49 UTC 2012

+1

--

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com

Sent from my iPhone

On Dec 18, 2012, at 8:51 PM, Joe Wang <huizhe.wang at oracle.com> wrote:

Thanks Tom. I changed it as you suggested.

I did initially remove the string and have main print out getVersion() instead, but I reverted it with a 2nd thought same as you, that it's /possible/ someone might be using it :) New webrev is here: http://cr.openjdk.java.net/~joehw/jdk8/8003261/webrev/ Joe On 12/18/2012 9:49 AM, Tom Hawtin wrote: Not that it's particularly important, but it's /possible/ clients are relying on the non-compile time constant nature of this field causing it not to be inlined into client class files, rather than the ability to switch the version string. So it may be a good idea to add the final, but make it a non-compile time constant. We can also remove the duplication.

public static final String fVersion = getVersion(); Tom On 18/12/2012 08:47, Joe Wang wrote: Hi,

This is the 2nd of the three [findbug] issues. The field fVersion is simply made final. webrev: http://cr.openjdk.java.net/~joehw/jdk8/8003261/webrev/ Test: No new test needed. Thanks, Joe

More information about the core-libs-dev mailing list