PPC Linux 64 needs -fsigned-char option for gcc (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Fri Dec 21 10🔞03 UTC 2012

On 21/12/2012 09:40, Sean Chou wrote:

Hello,

We found -fsigned-char is added to ppc platform, but not added to ppc64 platform. As they are different platforms, I think it is needed for ppc64 as well. Currently I just added one line modification as follow, but there may be more places to modify. If some one can give some comments, I can make a complete webrev. The buggy scenario we found needs closed code to reproduce, so it is not reproduced with current openjdk build on ppc linux from AIX porting project. I tested with ibmjdk, the patch works. I found CFLAGSREQUIREDppc is from changeset http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/54d8193f177b . Is it enough to add ppc64 option for places ppc appears in that patch? ///////////////////////// the patch //////////////////////// diff --git a/make/common/Defs-linux.gmk b/make/common/Defs-linux.gmk --- a/make/common/Defs-linux.gmk +++ b/make/common/Defs-linux.gmk @@ -196,6 +196,7 @@ LDFLAGSCOMMONsparc += -m32 -mcpu=v9 CFLAGSREQUIREDarm += -fsigned-char -DLITTLEENDIAN CFLAGSREQUIREDppc += -fsigned-char -DBIGENDIAN +CFLAGSREQUIREDppc64 += -fsigned-char -DBIGENDIAN ifeq ($(ZEROBUILD), true) CFLAGSREQUIRED = $(ZEROARCHFLAG) ifeq ($(ZEROENDIANNESS), little) You should probably bring this to build-dev to discuss. If the linux-ppc64 port is a jdk8 port then you should probably be looking at the new build and we should be cutting over soon.

-Alan

More information about the core-libs-dev mailing list