RFR : 8003228 : (props) sun.jnu.encoding should be set to UTF-8 [macosx] (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Fri Dec 21 15:33:02 UTC 2012

On 20/12/2012 22:20, Brent Christian wrote:

Forgot a regtest - now included w/ v.01:

http://cr.openjdk.java.net/~bchristi/8003228/webrev.01/ I think the change is okay, it would nice to have got an authoritative reference to give more confidence that this is the right thing but that doesn't seem to be possible.

I also think it's important that the folks on macosx-port-dev that have been complaining about this help us test it out, particularly folks that work in Asian locales. I don't know how many of them build the jdk so you might need to send a reminder once there is a jdk8 build available with this change. I don't think we should consider backporting this change to jdk7u until there is strong evidence that the change in jdk8 is good.

Thanks for creating a test. I'm not sure that test/java/util/Properties is right place as that directory is for tests of the java.util.Properties API. I guess I would move it to java/util/System as there isn't an obvious place in the sun/** tree. In ExpectedEncoding then it looks it is missing an exit in the bad usage case. Also as an alternative to the failed flag then you could just throw an exception.

-Alan.

More information about the core-libs-dev mailing list