RFR 2: JDK-8005263: Logging APIs takes Supplier for message (original) (raw)

Remi Forax forax at univ-mlv.fr
Sat Dec 22 12:45:25 UTC 2012

On 12/22/2012 12:13 PM, Peter Levart wrote:

Hi Henry,

Plain and simple.

yes,

I just noticed a few spellings: line 670, 696, 863: "Thus is it" -> "Thus it is" - this one has already been written wrong in the original source, so it just multiplied by copy-paste line 688, 743, 854: "Log a in-time" -> "Log an in-time"

and also there is no @since 1.8 for method log(Level, Supplier)

Regards, Peter

cheers, Rémi

On 12/22/2012 05:50 AM, Henry Jen wrote: Hi,

Update patch with review feedback, - JavaDoc update for benefit and gotcha. - logEx/logpEx is not log/logp with Supplier as last argument. As a matter of fact, all API with Supplier takes it as last argument. - No more doLog(Level, Supplier, Block) helper for performance concerns. Specdiff and webrev can be found at following, http://cr.openjdk.java.net/~henryjen/ccc/8005263.1/specdiff/diff.html http://cr.openjdk.java.net/~henryjen/ccc/8005263.1/webrev/ Cheers, Henry

More information about the core-libs-dev mailing list