Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file (original) (raw)
Joe Darcy joe.darcy at oracle.com
Thu Feb 2 19:26:55 UTC 2012
- Previous message: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file
- Next message: hg: jdk8/tl/jdk: 7141910: Incorrect copyright dates on new test cases.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks fine,
-Joe
On 2/1/2012 7:47 PM, Kumar Srinivasan wrote:
Hi Joe, David,
Thanks for the feedback, here is the modified delta webrev: http://cr.openjdk.java.net/~ksrini/7141141/webrev.1/webrev.delta/index.html
Changes are: * Eliminated typos and fixed the comments * Replaced @compile with @build * Replaced Throwable with IOException this makes it consistent. Thanks Kumar
Hello, On 2/1/2012 1:37 PM, Kumar Srinivasan wrote: Hi,
Here are some improvements to the launcher tests, contributed by Sonali Goel of the SQE team, please review: http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/ The CR: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7141141 Thanks Kumar
A few stylistic comments: 29 * @compile -XDignore.symbol.file MainClassAttributeTest.java It might suffice to use @build instead of @compile. 43 * only English is seleced and will pass vacuosly for other locales. 44 * 45 */ Extra line. 98 public static void main(String[] args) throws Throwable { Is it necessary to throw Throwable here? Otherwise looks fine. -Joe
- Previous message: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file
- Next message: hg: jdk8/tl/jdk: 7141910: Incorrect copyright dates on new test cases.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]