Need reviewer: JDK 8 CR for Support Integer overflow (original) (raw)

Tom Rodriguez tom.rodriguez at oracle.com
Mon Feb 6 23:59:43 UTC 2012

On Feb 3, 2012, at 8:37 PM, Krystal Mok wrote:

Hi Tom,

Yes, I'm sorry for not including enough context when cc'ing. The original discussion thread starts from [1]. The webrev is at [2]. For the string concats in multiplyExact(): * the StringBuilder doesn't escape * it's only concatenating Strings and ints

which should meet the requirements for OptimizeStringConcat to work,

That's right. I believe it would be able to optimize away the string construction work in this case.

tom

Regards, Kris Mok [1]: http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-February/009128.html [2]: http://cr.openjdk.java.net/~rriggs/CR6708398/webrev/ On Sat, Feb 4, 2012 at 1:47 AM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote: On Feb 3, 2012, at 12:38 AM, Krystal Mok wrote: > Hi Florian, > > On Fri, Feb 3, 2012 at 4:11 PM, Florian Weimer <fweimer at bfk.de> wrote: > Will Hotspot be able to optimize away the string construction on the > exception path in multiplyExact() if the exception is caught locally? > > At least -XX:+OptimizeStringConcat should remove the need to construct a StringBuilder instance, in multiplyExact()'s case. > > Cc'ing hotspot-compiler-dev for confirmation. Could we have some context? tom > > - Kris > >

More information about the core-libs-dev mailing list