Warning Fixes from LJC Hack Session (original) (raw)

Stuart Marks stuart.marks at oracle.com
Fri Feb 10 03:11:08 UTC 2012

Hi Mike,

I finally got back to this. These fixes look pretty good and knock off 100+ additional warnings! I've filed bug 7143230 [1] to track this. I took a look through the code and I took the liberty of fixing up a few very minor things:

  1. Removed unnecessary casts to ZipEntry in JarVerifier.java, suggested by Chirs Hegarty [2]. (These aren't strictly redundant casts, and don't cause warnings, as the origin types are <? extends ZipEntry> and JarEntry. However, they are unnecessary.)

  2. Fixed typo in unrelated comment at line 50 in SignatureFile.java that I happened to notice.

  3. Removed parentheses from expressions in MemoryMonitor.java lines 216, 219 which are now unnecessary since the cast has been removed.

No need to issue another patch; I'll just include these changes when I push the changeset.

Which brings me to the topic that we discussed before when I pushed LJC's previous round of warnings fixes, that is, how the Contributed-by line in the commit message should be formatted. (See [3] for the requirements.) For reference, here's what the changeset comment for the previous set of LJC fixes ended up looking like:

changeset: 4802:4f0f9f9c4892 user: smarks date: Wed Dec 07 12:12:50 2011 -0800 description: 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip Reviewed-by: alanb, dholmes, forax, sherman, smarks Contributed-by: Prasannaa <prasannaa_ss at yahoo.com>, Martijn Verburg <martijnverburg at gmail.com>, Goerge_Albrecht <goerge.albrecht at gmx.net>, Graham Allan <grundlefleck at googlemail.com>, Michael Barker <mikeb01 at gmail.com>

It looks like a different set of people contributed to this round of fixes. If you could send me the list of names and email addresses, I can format them into the commit message and push the fix.

Thanks!

s'marks

[1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143230

[2] http://mail.openjdk.java.net/pipermail/jdk8-dev/2012-February/000715.html

[3] http://openjdk.java.net/guide/producingChangeset.html

On 2/4/12 12:12 AM, Chris Hegarty wrote:

Thanks for this, looks great.

Good to see JarVerifier getting some much needed TLC. -Chris.

On 02/ 4/12 07:50 AM, Michael Barker wrote: I see Rémi has suggested a slice& dice but I think that's a bit too much work for the changes involved. Instead I would suggest a simple split, send the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else to core-libs-dev.

Attached is the patch that contains "everthing else" from LJC warning fixes hack session. Mike.

More information about the core-libs-dev mailing list