7121110 : JAXP 1.4.5 update 1 for 7u4 & jaxp source in jdk7 repo (original) (raw)

Kelly O'Hair kelly.ohair at oracle.com
Wed Feb 15 17:52:45 UTC 2012

On Feb 15, 2012, at 9:01 AM, Andrew Hughes wrote:

----- Original Message -----

Thanks Kelly!

Only just saw all this now I'm imported jdk7u4 into IcedTea7. Good news! Glad you decided to join us with having the source in tree!

Yeah... I know we had reasons for this drop zip stuff, but I want to crawl under a rock everytime it causes issues for people. :^(

Indeed, that was the original intention when you designed the bundle process. Besides the unfortunate download problem, it actually works great in terms of guaranteeing that we have one single editable source.

I've never understood why editability is an issue. Surely, all patches have to be reviewed (and for 6 and 7 release trees, approved by the release manager), so if you don't want a change to be made, you can just not approve it. Where's the issue?

The issue was that we had too many releases, too many people getting changes in and not notifying the jaxp or jaxws teams, and we had a series of regressions because of it. Back when we were using Teamware to manage the sources (SCCS based) it was also very difficult to understand what changes were made where, by who, and for what. Mercurial helped, open sourcing helped, and now Joe Wang is part of the jdk team (a welcome addition).

So the planets have re-aligned and we need to undo the drop zip madness I created. My apologies for the pains. :^(

Next, maybe we could start to work on migrating the jaxp project source into the jdk. But it's the holiday season, we don't have to think too hard :). In the meantime, we just have to make sure patches are applied to the jaxp project first (through JIRA report for example) since that's how our dev/test process is set up. This sounds good. Is it planned for jaxws too? How about CORBA? With IcedTea we've had to hack things in the build to work around the fact that these repos depend on stuff in the JDK, so having just the three repositories (langtools, hotspot and jdk) would be great!

First things first.. I'd like to pull the sources back into the jaxp and jaxws repos first. Solve the drop zip bundle stuff first. CORBA does not have drop zip bundles.

There were other reasons for separating out jaxp, jaxws, and corba from the rest of the jdk. If we determine that the need is no longer there, then we can undo it. I originally wanted to make it easier for these jaxp, jaxws, and corba teams to update their components of the jdk, so we got more updates, more reliable updates, tracked the updates, and easier updates. These teams were not jdk developers back then, and the integration of new versions into the jdk was horribly painful for them.

I think in general most jdk developers do not care about or need to see or work with the jaxp, jaxws, or corba sources. They are separate beasts, and that was why we separated them. It was a huge batch of source that was taken out of the normal jdk developer's domain. They were often updated separately, they had their own versions, they had their own teams and releases. I wanted to make it easy to bring in a new component version, and just as easily back it out. Having them in separate repos has it's positives.

-kto

--Joe On 12/24/2011 8:56 AM, Kelly O'Hair wrote: Looks great to me.

There is still the issue of making sure the right people (like you :^) are the ones patching this code, so we know what we have matches the public JAXP project. -kto On Dec 23, 2011, at 1:27 PM, Joe Wang wrote:

Hi All,

We have prepared a jaxp update for 7u4. The listed changes have been posted to the jdk7u-dev alias with "7u4 Request for approval for CR 7121110 - JAXP 1.4.5 update 1 for 7u4". With this update, we are adding jaxp sources back into the jdk7 repository, which means we are abandoning the jaxp bundle download process. This is a significant change. We'd like to hear if you have any concerns. If no objection, we'd like to push the change within the next week. The webrev is here: http://cr.openjdk.java.net/~joehw/jaxp145u1-changeset/webrev/ Thanks, Joe -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

More information about the core-libs-dev mailing list