Codereview request for 4153167: separate between ANSI and OEM code pages on Windows (original) (raw)

Xueming Shen xueming.shen at oracle.com
Thu Feb 16 20🔞00 UTC 2012

Thanks Alan, webrev has been updated accordingly.

http://cr.openjdk.java.net/~sherman/4153167/webrev <http://cr.openjdk.java.net/%7Esherman/4153167/webrev/>

-Sherman

On 02/15/2012 07:00 AM, Alan Bateman wrote:

On 13/02/2012 17:36, Xueming Shen wrote:

:

The webrev is at http://cr.openjdk.java.net/~sherman/4153167/webrev The changes look reasonable to me and looks like you have all the combinations of redirection covered. I'm not sure about the sun.std*.encoding properties as folks will find them. Probably okay for now. Minor comments - in System.java then it might be better to name the method newPrintStream. It would also be good to add a comment block to that method. In javapropsmd.c then I agree with Bill's comment that you don't need 64 bytes. Minor nit is that you don't need spaces are both sides of the *. -Alan.

More information about the core-libs-dev mailing list