Code review request: 7146763: Warnings cleanup in the sun.rmi and related packages (original) (raw)

Rémi Forax forax at univ-mlv.fr
Fri Feb 24 21:45:08 UTC 2012

On 02/24/2012 08:01 PM, Kurchi Hazra wrote:

Hi Stuart,

Thanks for the detailed explanation. Here is an updated webrev: http://cr.openjdk.java.net/~khazra/7146763/webrev.02/

Hi Kurchi, the field logClassConstructor should not be changed after all, it should be declared as a Constructor<? extends LogFile> so you can remove the cast to LogFile at line 542.

with this change, the patch looks good to me.

- Kurchi

cheers, Rémi

More information about the core-libs-dev mailing list