Patch to expand tz checking scope in TimeZone_md.c (original) (raw)
Jonathan Lu luchsh at linux.vnet.ibm.com
Tue Jan 10 03:09:27 UTC 2012
- Previous message: Code review request for javadoc problem in java.lang.invoke.MethodHandle
- Next message: hg: jdk8/tl/jdk: 7128512: Javadoc typo in java.lang.invoke.MethodHandle
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi core-libs-dev,
Here's another approach to just add a defined(AIX) check to make sure it works on Aix platform. http://cr.openjdk.java.net/~luchsh/timezone_md_ret_check/
Any suggestions?
Cheers,
- Jonathan
On 11/02/2011 04:56 PM, Jonathan Lu wrote:
Hi core-libs-dev,
In jdk/src/solaris/native/java/util/TimeZonemd.c, starting from line 626, I found that the scope of "#ifdef solaris" might be too narrow, since it also works for some kind of OS which I'm currently working on, such as AIX. So I suggest to just remove the '#ifdef solaris' and leave the "#else" to accommodate more conditions, see attachment 'patch.diff'. I think this may enhance the cross-platform ability, any ideas about this modification? Regards - Jonathan Lu
- Previous message: Code review request for javadoc problem in java.lang.invoke.MethodHandle
- Next message: hg: jdk8/tl/jdk: 7128512: Javadoc typo in java.lang.invoke.MethodHandle
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]