Please review: 7125442 (original) (raw)
Joe Darcy joe.darcy at oracle.com
Wed Jan 11 01:38:13 UTC 2012
- Previous message: Please review: 7125442
- Next message: JDK 8 code review request for 7112008 Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class Instances
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 01/10/2012 01:14 PM, Mandy Chung wrote:
I18NJarTest.java L29: Is -XDignore.symbol.file really needed? As far as I see, the test only uses the public APIs. L79: should it check if the returned value is false?
Otherwise, looks good.
Looks fine,
-Joe
Mandy On 1/10/2012 1:06 PM, Kumar Srinivasan wrote: sorry I pasted the wrong webrev in the email, here is the right one... http://cr.openjdk.java.net/~ksrini/7125442/
Kumar
Hi, Please review: CR: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7125442 Webrev: http://cr.openjdk.java.net/~ksrini/7124443/ Thanks Kumar
- Previous message: Please review: 7125442
- Next message: JDK 8 code review request for 7112008 Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class Instances
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]