POSIX compatibility change for including wait.h in UNIXProcess_md.c (original) (raw)

David Holmes david.holmes at oracle.com
Thu Jan 12 10:13:51 UTC 2012

Hi Jonathon,

On 12/01/2012 7:35 PM, Jonathan Lu wrote:

It was found that solaris/native/java/lang/UNIXProcessmd.c includes <wait.h> which does not seem to be compliant with POSIX specification, in which the expected header file name should be <sys/wait.h>. see http://en.wikipedia.org/wiki/CPOSIXlibrary. I also performed a 'grep' for the code base, it seems nowhere else needs to be changed so far.

So here is a simple patch to adjust this issue, any suggestions? http://cr.openjdk.java.net/~luchsh/waithPOSIXcomp/

It looks like this is a remnant from when we used waitid on Solaris. Now we use waitpid <sys/wait.h> is more correct - as per the man page. On Linux wait.h simply includes sys/wait.h so no issue there.

This change looks okay to me. If Martin is still lurking here he may be able to confirm.

David

More information about the core-libs-dev mailing list