JDK 8 code review request for initial unsigned integer (original) (raw)

Rémi Forax forax at univ-mlv.fr
Wed Jan 18 19:47:12 UTC 2012

On 01/18/2012 08:21 PM, Roger Riggs wrote:

A comment or two on the webrev for unsigned:

http://cr.openjdk.java.net/~darcy/4504839.2 1. In the new parsing methods, could the String arguments be changed to the more general java.lang.CharSequence? For many parsing applications, it could be more convenient to pass a CharSequence than to create a new String. For consistency, should all of the parse methods be converted from String to CharSequence?

Good idea ! I've written a simple parser generator and after analyzing the perf of an HTTP parser generated by that tool a colleague of mine wrote a set of methods to convert a CharSequence to primitive value to avoid to allocate transient String objects.

2. To be consistent, the new thrown exception messages should not end with a period (".") Roger

Rémi

More information about the core-libs-dev mailing list