JDK 8 code review request for 7132338 Use @code friendly idiom for '' in javadoc (original) (raw)

Ulf Zibis Ulf.Zibis at gmx.de
Mon Jan 23 18:29:01 UTC 2012

Am 23.01.2012 18:53, schrieb Joe Darcy:

Well, there is the make/scripts directory in the the top-level JDK repository forest. Could you please publish your script there? (maybe via this patch)

Joe, thanks for catching my change proposal. Would like to see me as contributor :-) I meant via the "contributed-by" line in the final HG change set.

I was only attempting to replace the awkward HTML with used to render "\u..." with less awkward javadoc just using {@code}, but if I was in a file, I replaced the other usages to.

Thanks, ok. Was not obvious from the bugs subject line.

Additionally I see inconsistent indentations e.g. in AbstractStringBuilder: lines 838-846 lines 1241-1244 vs. 1259-1265

... and I still think, using 'unsigned {@code int}' in e.g. Integer.java line 628 is not correct, as there is no unsigned int in Java for now. Suggestion: 'unsigned 32-bit integer'

-Ulf

More information about the core-libs-dev mailing list