Code Review Request Bug #7129185:(coll) Please add Collections.emptyNavigableSet() (original) (raw)

Joseph Darcy joe.darcy at oracle.com
Mon Jan 23 23:44:31 UTC 2012

Hello Darryl,

On 1/23/2012 3:19 PM, Darryl Mocek wrote:

Re-sending this with the synopsis in the subject line (and the correct bug #).

Hello core-libs. Please review this patch to fix Bug #7129185. This fix addresses comments made by Jason Mehrens to the commit of the fix for bug #4533691, including adding a Collections.emptyNavigableSet method. Tests are included. Webrev, can be found here: http://cr.openjdk.java.net/~dmocek/7129185/webrev.00

I recommend using some different javadoc idioms. For example, I'd replace

3209 * 

3210      *     NavigableSet ns = 
Collections.emptyNavigableSet();
3211      *

with

{@code NavigableSet ns = Collections.emptyNavigableSet();}

and replace Foo with {@code Foo}.

-Joe

More information about the core-libs-dev mailing list