Review needed for 7132879 to address the findbug errors in WebRowSetXmlWriter (original) (raw)

Lance Andersen - Oracle lance.andersen at oracle.com
Tue Jan 24 18:50:22 UTC 2012

You are suggesting changing

java.util.Map typeMap = caller.getTypeMap();

to

Map typeMap = caller.getTypeMap();

Which I can do. I probably did not think about it much as it was their previously but I agree that would be the way to go.

Please let me know if I am on point with your suggestion

Best Lance On Jan 24, 2012, at 1:29 PM, Remi Forax wrote:

Looks good. The only weird thing is the use of java.util.Map instead of Map. Because Map is used in when referencing Map.Entry just after.

Rémi

----- Reply message ----- From: "Lance Andersen - Oracle" <lance.andersen at oracle.com> To: "core-libs-dev Libs" <core-libs-dev at openjdk.java.net> Subject: Review needed for 7132879 to address the findbug errors in WebRowSetXmlWriter Date: Tue, Jan 24, 2012 19:18 Hi, Looking for a reviewer for http://cr.openjdk.java.net/~lancea/7132879/webrev.00/ this is a small change to address 2 findbug errors for this class. The findbug issues being addressed: Inefficient use of keySet iterator instead of entrySet iterator and non-serializable instance field in serializable class Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com

More information about the core-libs-dev mailing list