Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Thu Jul 12 07:16:25 UTC 2012
- Previous message: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node
- Next message: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 12/07/2012 00:45, Kurchi Hazra wrote:
On 7/11/12 4:24 PM, Chris Hegarty wrote:
On 12 Jul 2012, at 00:15, Kurchi Hazra<kurchi.subhra.hazra at oracle.com> wrote:
Thanks for the review Alan. Updated webrev: http://cr.openjdk.java.net/~khazra/7160252/webrev.01/ Looks fine. Trivially, is there an opportunity to make any fields final since initFields is replaced with a constructor? Thanks for pointing that out. How about: http://cr.openjdk.java.net/~khazra/7160252/webrev.02/ Looks fine except that the test case is missing from latest webrev. Assuming that test/java/util/prefs/AddNodeChangeListener.java hasn't changed from the original webrev then I think you are all set to push.
-Alan.
- Previous message: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node
- Next message: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]