Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node (original) (raw)

Kurchi Hazra kurchi.subhra.hazra at oracle.com
Fri Jul 13 22:16:31 UTC 2012

I am pushing this changeset but backing out the changes to ProblemList.txt. Those tests are still failing depending on the machine and user permissions. I have a fair idea what is going wrong with them, and will work on them with their associated CR (7150557).

Thanks, Kurchi

On 7/12/2012 7:55 AM, Kurchi Subhra Hazra wrote: > I used a new workspace and missed adding it to mercurial. The test > remains the same, > I'll push it after adding the test. >> - Kurchi >> On 7/12/12 12:16 AM, Alan Bateman wrote: >> On 12/07/2012 00:45, Kurchi Hazra wrote: >>> On 7/11/12 4:24 PM, Chris Hegarty wrote: >>>> On 12 Jul 2012, at 00:15, Kurchi >>>> Hazra<kurchi.subhra.hazra at oracle.com> wrote: >>>>>>>>> Thanks for the review Alan. Updated webrev: >>>>> http://cr.openjdk.java.net/~khazra/7160252/webrev.01/ >>>> Looks fine. >>>>>>>> Trivially, is there an opportunity to make any fields final since >>>> initFields is replaced with a constructor? >>>>>> Thanks for pointing that out. How about: >>> http://cr.openjdk.java.net/~khazra/7160252/webrev.02/ >> Looks fine except that the test case is missing from latest webrev. >> Assuming that test/java/util/prefs/AddNodeChangeListener.java hasn't >> changed from the original webrev then I think you are all set to push. >>>> -Alan. >

-Kurchi

More information about the core-libs-dev mailing list