Please review: 7184145 pack200 NPE (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Sat Jul 14 20:34:31 UTC 2012

On 14/07/2012 20:32, Kumar Srinivasan wrote:

Hi,

Please review the following bug, it is not yet available on bugs.sun.com, there is a discussion thread jdk7u-dev at openjdk.java.net http://cr.openjdk.java.net/~ksrini/7184145/ The change looks good to me, thanks for sorting it out quickly. I guess we'll see if it can be fixed in 7u6 too.

The only comment I have on the webrev is the term "orphan" in the test seems a bit odd, I guess I would have said "tests repacking of a jarfile specified by a simple file name". It's not an interesting point so thumbs up from me.

-Alan

More information about the core-libs-dev mailing list