Review request CR 7171918 XmlReaderContentHandler.endElement does not handle a Delete Tag properly (original) (raw)
Lance Andersen - Oracle Lance.Andersen at oracle.com
Tue Jun 5 14:17:19 UTC 2012
- Previous message: Fwd: Review request for CR 171917 CachedRowSetImpl.populate does not handle map properly
- Next message: Failing jdk testcase: java/lang/Math/WorstCaseTests.java
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Also looking for a reviewer still here. As with the other changes, all SQE, Junit and JCK tests pass
Best Lance On May 25, 2012, at 3:56 PM, Lance Andersen - Oracle wrote:
Attached is the fix for 7171918. If a WebRowSet is written to disk that contains a row marked for deletion and then read back into a WebRowSet, it was not marked again as a deleted row.
Here is the fix to endElement() to address this. hg diff XmlReaderContentHandler.java diff -r 4580652d9828 src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java --- a/src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java Fri May 04 16:00:47 2012 -0400 +++ b/src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java Fri May 25 15:52:21 2012 -0400 @@ -764,6 +764,7 @@ rs.next(); rs.setOriginalRow(); applyUpdates(); + rs.deleteRow(); } catch (SQLException ex) { throw new SAXException(MessageFormat.format(resBundle.handleGetObject("xmlrch.errdel").toString() , ex.getMessage()));
Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com
- Previous message: Fwd: Review request for CR 171917 CachedRowSetImpl.populate does not handle map properly
- Next message: Failing jdk testcase: java/lang/Math/WorstCaseTests.java
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]