Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node (original) (raw)
Kurchi Hazra kurchi.subhra.hazra at oracle.com
Tue Jun 26 21:57:34 UTC 2012
- Previous message: hg: jdk8/tl/jdk: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)
- Next message: hg: jdk8/tl/jaxp: 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
On Mac OS X, for Preferences, a new child added event was not beingdelivered to a NodeChangeListener since the existing code depended on the return value of addNode() in the native code, which returns true if a new node is added. However, since addNode() was being called erroneously after a child node is already added to an existing node, addNode() would always return false, resulting in thw new node event never being delivered.
This fix propagates the required information of whether a node is added from the method adding the child node itself. In addition, I cleaned up the constructors in MacOSXPreferences.java and added a test (AddNodeChangeListener.java) to cover this case.
Finally, there were two prefs tests in ProblemList.txt which are now passing, I have removed these from the ProblemList too.
Bug: http://bugs.sun.com/view_bug.do?bug_id=7160252 Webrev: http://cr.openjdk.java.net/~khazra/7160252/webrev.00/
Thanks, Kurchi
- Previous message: hg: jdk8/tl/jdk: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)
- Next message: hg: jdk8/tl/jaxp: 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]