RFR 7147666 : High lock time for com.sun.org.apache.xerces.internal.impl.dv.DTDDVFactory.getInstance() (original) (raw)

Andrew Hughes ahughes at redhat.com
Mon Mar 5 19:41:24 UTC 2012

----- Original Message -----

Hi all,

This is a low risk, proven patch made in Xerces back in 2007 [1], removing unnecessary "synchronization" in DTDDVFactory. As reported in 7147666, this patch improves performance in one of the xml test. Webrev : http://cr.openjdk.java.net/~joehw/7u4/cr7147666/webrev/ [1] http://svn.apache.org/viewvc?view=revision&revision=558581 Please review. Thanks, Joe

Seems like an obvious fix to me. The classname is initialised as part of the static initialisation of the class and doesn't change. There's no need to lock the class to create instances AFAICS.

Were the whitespace changes in this webrev deliberate?

Thanks,

Andrew :)

Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

More information about the core-libs-dev mailing list