RFR 7147666 : High lock time for com.sun.org.apache.xerces.internal.impl.dv.DTDDVFactory.getInstance() (original) (raw)

Joe Wang huizhe.wang at oracle.com
Mon Mar 5 21:22:27 UTC 2012

Thanks Andrew, Alan and Lance for the quick review!

I agree, there's no need for the synchronization in the current code.
It was historical. There was a public set method in its earlier versions.

The whitespace was intentional to keep it in sync with Apache code, just so we don't get the class to show up in any future diff operation.

-Joe

On 3/5/2012 1:02 PM, Lance Andersen - Oracle wrote:

looks ok joe

-lance On Mar 5, 2012, at 1:46 PM, Joe Wang wrote:

Hi all,

This is a low risk, proven patch made in Xerces back in 2007 [1], removing unnecessary "synchronization" in DTDDVFactory. As reported in 7147666, this patch improves performance in one of the xml test. Webrev : http://cr.openjdk.java.net/~joehw/7u4/cr7147666/webrev/ <http://cr.openjdk.java.net/%7Ejoehw/7u4/cr7147666/webrev/> [1] http://svn.apache.org/viewvc?view=revision&revision=558581 <http://svn.apache.org/viewvc?view=revision&revision=558581> Please review. Thanks, Joe <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>

More information about the core-libs-dev mailing list