Suggestion about including pthread.h (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Fri Mar 9 09:04:23 UTC 2012
- Previous message: Suggestion about including pthread.h
- Next message: Suggestion about including pthread.h
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 09/03/2012 08:01, Shi Jun Zhang wrote:
The situation in NativeThread.c is more complicated than other 2 files. I'm not familiar with BSD or Mac. It seems that we don't need to signal threads on BSD or Mac. And INTERRUPTSIGNAL on AIX will definitely be different from the one on Linux. I think we'd better separate the changes in NativeThread.c from this patch and try to solve it later. Right, if signals are required there is likely to be differences across platforms. It is also likely that this code will need to be changed for Mac too as there are a couple of preemptive close issues to sort out (for file operations, sockets are okay).
The change to socketmd.c looks okay to me but you will need to re-base your patch due to the Mac port in jdk8/tl. I'm a new comer and i got known from Charles about the difference between jdk8 and jdk8/tl. The latest webrev is based on jdk8/tl. http://cr.openjdk.java.net/~zhangshj/pthread/webrev.01/ The changes in this webrev look okay to me.
-Alan.
- Previous message: Suggestion about including pthread.h
- Next message: Suggestion about including pthread.h
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]