RFR : 7149608 (tz): Default TZ detection fails on linux when symbolic links to non default location used. (original) (raw)

Masayoshi Okutsu masayoshi.okutsu at oracle.com
Tue Mar 13 09:51:20 UTC 2012


Looks good to me.

Masayoshi

On 3/13/2012 6:38 PM, Seán Coffey wrote:

Update made. Hopefully the last iteration ;)

http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.4/ regards, Sean. On 13/03/2012 05:59, Masayoshi Okutsu wrote: fd needs to be closed when fstat or malloc failed?

Thanks, Masayoshi On 3/13/2012 12:22 AM, Alan Bateman wrote: On 12/03/2012 15:11, Seán Coffey wrote: Yes - good catch. I hadn't tested the sym link being a relative path. We should always open whatever is pointed to from DEFAULTZONEINFOFILE. This simplifies the code. Tested and looks good. I assume this is the latest: http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.3/

and it looks fine to me. -Alan.



More information about the core-libs-dev mailing list