Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec (original) (raw)

Ulf Zibis Ulf.Zibis at gmx.de
Tue Mar 13 19:11:41 UTC 2012


Am 10.03.2012 13:42, schrieb David Holmes:

On 9/03/2012 11:39 PM, Ulf Zibis wrote:

Regarding your Infrastructure: It is stated, that jtreg is able to process standard JUnit testcases, so IMHO there is no need to recode similar infrastructure. I simply copied am existing test: AbstractCollection/ToString.java As such infrastructure is quite general for many testcases, IMO it would be resonable to provide it in a separate class in the test tree, regardless if manually coded or using JUnit.

Additionally I think, we need to check + test, if all known inheritors of Collection/AbstractCollection behave same. If any concrete collection overrides toArray - sure. E.G. ArrayDeque, ArrayList, Vector, any internal values(), entrySet(), keySet() implementation of all Maps.

-Ulf



More information about the core-libs-dev mailing list