Review request for 8001536 updated (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Nov 1 18:03:25 UTC 2012


On 31/10/2012 15:08, Lance Andersen - Oracle wrote:

Here is revised webrev taking into account Remi's suggestions http://cr.openjdk.java.net/~lancea/8001536/webrev.01/

I skimmed over the updated webrev and the changes mostly look okay to me.

One comment on the clone method is that "The internal {@code Blob} field will be set to null" doesn't seem right. Shouldn't this say that the resulting object doesn't have an underlying Blob?

I don't know if you want formatting/type comments but a couple of nits:

-Alan.



More information about the core-libs-dev mailing list