Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract (original) (raw)
Chris Hegarty chris.hegarty at oracle.com
Wed Nov 7 10:16:40 UTC 2012
- Previous message: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract
- Next message: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
The change looks fine to me.
I wonder if it is worth creating an automatic regression test to verify this change ( so an future regression in behavior gets caught early ). You could call sun.tools.jar.Main directly passing suitable streams to check the output.
-Chris.
On 07/11/2012 08:31, Sean Chou wrote:
Hello,
This is the suggested fix described in sun bug 7201156 page. Please take a look. sunbug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7201156 webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.00/
- Previous message: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract
- Next message: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]