[PATCH FOR REVIEW] ResourceManager.getApplicationResources() does not close InputStreams (original) (raw)

David Holmes david.holmes at oracle.com
Thu Nov 8 03:47:25 UTC 2012

On 8/11/2012 7:17 AM, Andrew Hughes wrote:

----- Original Message -----

The bug number is 8003120

Thanks. Pushed to tl: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f51943263267

I did not construe Lance's mail to indicate an approval to push. The turnaround on this was just a bit too quick in my opinion.

David

Best Lance On Nov 7, 2012, at 3:30 PM, Andrew Hughes wrote:

IcedTea bug: http://icedtea.classpath.org/bugzilla/showbug.cgi?id=1197

com.sun.naming.internal.ResourceManager.getApplicationResources() does not close the input streams it gets from helper.getResources() and helper.getJavaHomeLibStream(). This patch: http://cr.openjdk.java.net/~andrew/pr1197/webrev.01/ adds finally blocks to close these streams. As noted in the original bug report, this has been tested on a J2EE server (JBoss) without issue. I realise that there's a possibility that try-with-resources could be used here, but the patch as posted is the one that was tested and I don't want to negate that testing by changing it. Ok for tl? If so, can I have a bug ID for this? Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com

More information about the core-libs-dev mailing list