[PATCH FOR REVIEW] ResourceManager.getApplicationResources() does not close InputStreams (original) (raw)

Andrew Hughes gnu.andrew at redhat.com
Tue Nov 13 17:29:38 UTC 2012

----- Original Message -----

On 07/11/2012 20:51, Andrew Hughes wrote: > : > > As you can see on the IcedTea bug, I've asked the same question. > I'd have preferred it to use try-with-resources myself (easier to > follow for one thing), but given the patch is as it is, I'm now > wary about changing it and negating the existing testing that's > already been done. > I see you've pushed this already but I think we need to open a follow-on bug on this as it looks like there is additional work to do. Particularly the case where there are several streams and close fails (looks to me that it will not attempt to close all streams in that case). Also, given that the target is jdk8 then it seems reasonable to see if try-with-resources could be used for the second case, I assume the testing you mentioned was with a different release. The other thing is that we try to include a regression test with all fixes where possible, I don't know how feasible it for this case.

The testing was on 7u as there isn't an 8 release yet.

I'm not sure how you'd test this either.

-Alan. >>

Andrew :)

Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

More information about the core-libs-dev mailing list