Request for Review : 7175464 : entrySetView field is never updated in NavigableSubMap (original) (raw)

David Holmes david.holmes at oracle.com
Thu Nov 15 05:05:32 UTC 2012

Hi Mike,

On 15/11/2012 3:49 AM, Mike Duigou wrote:

Hello all;

A small but useful performance fix for sub-maps of TreeMap: http://cr.openjdk.java.net/~mduigou/7175464/0/webrev/ The entrySetView was not being cached.

Seems a bug that entrySetView was never being set, but given that it wasn't this may now introduce an incompatability may it not? Even if the spec permits caching for how long have we always returned a new instance?

David

There is no unit test because either implementation is permissible under the specification. The fix only has the effect of improving performance and reducing duplicate objects.

Mike

More information about the core-libs-dev mailing list