Review Request for 8000712 (original) (raw)
Lance Andersen - Oracle Lance.Andersen at oracle.com
Wed Oct 10 21:06:09 UTC 2012
- Previous message: hg: jdk8/tl/jdk: 7192274: Deprecate LogManager addPropertyChangeListener and removePropertyChangeLister methods
- Next message: Review Request for 8000712
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
Looking for a reviewer for the removal of the following non-used fields in SyncFactory
private static String default_provider
private static Level rsLevel private static Object logSync private static java.io.PrintWriter logWriter
Best Lance
new-host-2:spi lanceandersen$ hg diff SyncFactory.java diff -r 3c4be36de073 src/share/classes/javax/sql/rowset/spi/SyncFactory.java --- a/src/share/classes/javax/sql/rowset/spi/SyncFactory.java Wed Oct 10 11:15:27 2012 -0400 +++ b/src/share/classes/javax/sql/rowset/spi/SyncFactory.java Wed Oct 10 16:57:46 2012 -0400 @@ -1,5 +1,5 @@ /*
- Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved.
- Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved.
- DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- This code is free software; you can redistribute it and/or modify it
@@ -229,11 +229,7 @@
- The standard resource file name. */ private static String ROWSET_PROPERTIES = "rowset.properties";
- /**
* The RI Optimistic Provider.*/- private static String default_provider =
"com.sun.rowset.providers.RIOptimisticProvider";
/** * Permission required to invoke setJNDIContext and setLogger */
@@ -248,24 +244,13 @@
* The Logger object to be used by the SyncFactory.
*/
private static volatile Logger rsLogger;
- /**
**/- private static Level rsLevel;
/** * The registry of available <code>SyncProvider</code> implementations. * See section 2.0 of the class comment for <code>SyncFactory</code> for an * explanation of how a provider can be added to this registry. */ private static Hashtable<String, SyncProvider> implementations;
/**
* Internal sync object used to maintain the SPI as a singleton*/private static Object logSync = new Object();
/**
* Internal PrintWriter field for logging facility*/private static java.io.PrintWriter logWriter = null;
/**
- Adds the the given synchronization provider to the factory register. Guidelines
new-host-2:spi lanceandersen$
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com
- Previous message: hg: jdk8/tl/jdk: 7192274: Deprecate LogManager addPropertyChangeListener and removePropertyChangeLister methods
- Next message: Review Request for 8000712
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]