Reviewer needed for 8000763: use XXX.valueOf methods instead of constructors (original) (raw)

Lance Andersen - Oracle Lance.Andersen at oracle.com
Thu Oct 11 17:34:15 UTC 2012


Hi Remi,

Thank you for the suggestion, I had forgotten about parseDouble. I made your suggested change below.

Best Lance

new-host-2:rowset lanceandersen$ hg diff diff -r c2be39b27e1c src/share/classes/com/sun/rowset/CachedRowSetImpl.java --- a/src/share/classes/com/sun/rowset/CachedRowSetImpl.java Thu Oct 11 11:47:05 2012 +0100 +++ b/src/share/classes/com/sun/rowset/CachedRowSetImpl.java Thu Oct 11 13:32:41 2012 -0400 @@ -1,5 +1,5 @@ /*

@@ -4432,7 +4427,7 @@ // make sure the cursor is on a valid row checkCursor();

@@ -4467,7 +4462,7 @@ checkIndex(columnIndex); // make sure the cursor is on a valid row checkCursor();

diff -r c2be39b27e1c src/share/classes/com/sun/rowset/FilteredRowSetImpl.java --- a/src/share/classes/com/sun/rowset/FilteredRowSetImpl.java Thu Oct 11 11:47:05 2012 +0100 +++ b/src/share/classes/com/sun/rowset/FilteredRowSetImpl.java Thu Oct 11 13:32:41 2012 -0400 @@ -1,5 +1,5 @@ /*

@@ -906,7 +906,7 @@

   if(onInsertRow) {
      if(p != null) {

diff -r c2be39b27e1c src/share/classes/javax/sql/rowset/BaseRowSet.java --- a/src/share/classes/javax/sql/rowset/BaseRowSet.java Thu Oct 11 11:47:05 2012 +0100 +++ b/src/share/classes/javax/sql/rowset/BaseRowSet.java Thu Oct 11 13:32:41 2012 -0400 @@ -1,5 +1,5 @@ /*

@@ -1882,7 +1882,7 @@ if(params == null){ throw new SQLException("Set initParams() before setDouble"); }

diff -r c2be39b27e1c src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java --- a/src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java Thu Oct 11 11:47:05 2012 +0100 +++ b/src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java Thu Oct 11 13:32:41 2012 -0400 @@ -215,7 +215,7 @@ */ @SuppressWarnings("unchecked") public void writeFloat(float x) throws SQLException {

@@ -230,7 +230,7 @@ */ @SuppressWarnings("unchecked") public void writeDouble(double x) throws SQLException{

new-host-2:rowset lanceandersen$ On Oct 11, 2012, at 12:59 PM, Remi Forax wrote:

return Double.compare(Double.parseDouble(value.toString()), 0) != 0;

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com



More information about the core-libs-dev mailing list