Code Review Request: 7198073: (prefs) user prefs not saved [macosx] (original) (raw)
Kurchi Hazra kurchi.subhra.hazra at oracle.com
Fri Oct 12 00:21:11 UTC 2012
- Previous message: hg: jdk8/tl/jdk: 8000763: use XXX.valueOf methods instead of constructors
- Next message: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
This is a regression introduced by the fix for 7160252[1] that I pushed a few weeks ago. We should really be using the class member field isUser, rather than the argument passed in the constructor as a parameter for cfFileForNode(). Due to this wrong parameter being passed, user preferences were never getting stored into permanent storage.
Webrev: http://cr.openjdk.java.net/~khazra/7198073/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198073
Thanks, Kurchi
[1] http://cr.openjdk.java.net/~khazra/7160252/webrev.02/
- Previous message: hg: jdk8/tl/jdk: 8000763: use XXX.valueOf methods instead of constructors
- Next message: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]