Code Review Request: 7198073: (prefs) user prefs not saved [macosx] (original) (raw)
Kurchi Subhra Hazra kurchi.subhra.hazra at oracle.com
Tue Oct 16 15:55:46 UTC 2012
- Previous message: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]
- Next message: 8000685: (props) Properties.storeToXML/loadFromXML should only require UTF-8 and UTF-16 to be supported
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 10/16/12 2:54 AM, Alan Bateman wrote:
On 16/10/2012 01:53, Kurchi Hazra wrote:
Hi Alan,
Please find an updated webrev with a test included: http://cr.openjdk.java.net/~khazra/7198073/webrev.01/ CheckUserPrefsStorage.sh is the main entry point - it runs CheckUserPrefFirst first (which creates and attempts to store a preference), and then runs CheckUserPrefLater (which attempts to retrieve the preference stored by the former). Thanks for adding a test, it looks good to me, I just wonder if we should run with java.util.prefs.userRoot=. so that we don't leave anything behind in the event that CheckUserPrefLater doesn't run.
That did occur to me, but I have not yet checked what java.util.prefs.userRoot=. actually implies while using jtreg. When I get more time to work on 7197662, I will be updating all the prefs test including this one.
Thanks, Kurchi
- Previous message: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]
- Next message: 8000685: (props) Properties.storeToXML/loadFromXML should only require UTF-8 and UTF-16 to be supported
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]