RFR: 6594697 - varargs message and Throwable methods for java.util.Logger (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Tue Oct 30 18:30:45 UTC 2012
- Previous message: RFR: 6594697 - varargs message and Throwable methods for java.util.Logger
- Next message: RFR: 6594697 - varargs message and Throwable methods for java.util.Logger
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 30/10/2012 14:21, Jim Gish wrote:
I was one the fence with the parameter ordering and would like additional feedback on this point. I started off as you suggested, but didn't like the fact that the params were separated from the msg by the Throwable. I could go either way, but would like to hear from others on this point.
Thanks, Jim I think it make sense to keep the message and its parameters together, and since the parameters have to be at the end then it does mean the Throwable comes before the message. It does mean that there is a bit of inconsistency in the ordering but it might be a bit odd to put the Throwable between the message and its parameters.
I think the changes to use isLoggable should be separated out into their own issue.
-Alan
- Previous message: RFR: 6594697 - varargs message and Throwable methods for java.util.Logger
- Next message: RFR: 6594697 - varargs message and Throwable methods for java.util.Logger
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]