Review request for 7192302 Remove JDBCRowSetImpl dependency on java.beans (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Sep 6 14:49:13 UTC 2012

On 06/09/2012 14:45, Lance Andersen - Oracle wrote:

: connect() is typically called to get a connection and it will validate that there is a non-null Connection. I have unit tests which leverage that constructor and run clean with that change. I agree that commit(), rollback, etc should call checkState() and that is another fix I need to do but the potential for the NPE is there depending on which constructor was used and if you did something silly like making a rollback without doing any work. I'm okay with what you have if you make sure to submit a bug as a reminder to clean-up this code.

-Alan

More information about the core-libs-dev mailing list