[8] Review request for 7196354 check-in jdk.tbom file to openjdk repo (original) (raw)

mark.reinhold at oracle.com mark.reinhold at oracle.com
Thu Sep 6 20:29:23 UTC 2012

2012/9/5 14:08 -0700, michael.fang at oracle.com:

Please help to review the new JDK8 file for the following CR: 7196354 check-in jdk.tbom file to openjdk repo

The webrev is located at: http://cr.openjdk.java.net/~mfang/7196354/webrev.00/

This file needs a more descriptive name, especially if it's going to be in the root of the source tree. Suggestion: translated-files.xml .

Is there a DTD or a schema for this file? I can guess what most of it means, but I might guess incorrectly.

[line 8] "OpenJDK" isn't a component, it's a community. I think you mean "JDK" here.

The "JDK" / "JRE" division in this file is somewhat artificial and likely to become incorrect over time -- not every developer knows exactly which files are in the JRE vs. the full JDK. I suggest doing away with that division and simply sorting the file-set elements by source file name.

At a glance it looks like the source and target attributes for any given file are identical. Do you expect there to be cases where they're different?

...

Mark: Since the dev team will need to maintain this file in the future (modifying it if you add or delete resource files), I temporarily put down your name as contact for the file. Please figure out the proper owner and we can update it again.

We don't put contact names in source code. Please remove my name, and do not add another.

...

In the future, if any bug/rfe requires adding/deleting resource files, the dev work should include updating this file to reflect the correct resource file list. (and please ask me to review it).

If you expect other people to update this file over time then you need to document that expectation somewhere and, as importantly, you need to document the syntax and semantics of the file. Fortunately we have a way to do that, namely the JEP process (http://openjdk.java.net/jeps/). I suggest you draft a JEP for this and circulate it for review along with the webrev.

More information about the core-libs-dev mailing list