Review Request: JDK-8000406 (original) (raw)

Review Request: JDK-8000406 - change files using @GenerateNativeHeader to use @Native

Anthony Petrov anthony.petrov at oracle.com
Tue Apr 2 12:07:38 UTC 2013

Hi Dan,

Changes to awt code look fine to me.

-- best regards, Anthony

On 4/2/2013 2:16, Dan Xu wrote:

Hi All,

In this fix, I have updated files in JDK libraries to use @Native annotation instead of @GenerateNativeHeader to mark classes that contain no native methods but constants used by native codes. @GenerateNativeHeader was added earlier in the development for JDK8. "This has proved problematic for some core classes with respect to Jigsaw, since the use of such an annotation creates a compile-time dependency from the base module to the module containing javax.tools, and the base module should not have any dependencies." After switching to @Native annotation, the dependency problem will be solved as java.lang.annotation.Native is in the proposed base module. In addition, the annotation has been refined not to be on the class level but on the constants themselves, which also makes the generated header files much cleaner. This effort is part of JDK-8000404. After jdk libraries uptaking the annotation changes, @GenerateNativeHeader annotation will be removed completely. CCC: http://ccc.us.oracle.com/8000404 webrev: http://cr.openjdk.java.net/~dxu/8000406/webrev/ Thanks for your feedback! -Dan

More information about the core-libs-dev mailing list