Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK (original) (raw)

Jeroen Frijters jeroen at sumatra.nl
Wed Apr 3 19:52:14 UTC 2013

Hi,

Thanks for this. This is a really great change.

I reviewed the changes and my only comment is that there is a typo in java/lang/reflect/Field.java ("scurity").

Somewhat unrelated (but relevant for my implementation of CallerSensitive), but would it be possible to mark java.lang.Runtime as final, or at least make the CallerSensitive methods final?

The interaction between CallerSensitive and method overriding is non trivial, so IMO it is best avoided.

Thanks, Jeroen

From: core-libs-dev-bounces at openjdk.java.net [core-libs-dev-bounces at openjdk.java.net] on behalf of Mandy Chung [mandy.chung at oracle.com] Sent: Wednesday, April 03, 2013 8:49 PM To: John Rose Cc: Christian Thalinger; core-libs-dev Subject: Re: Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK

This version has corrected to use Class.getMethod to determine if the checkMemberAccess method is overridden in the subclass:

http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7198429/webrev.02/

thanks Mandy

On 4/2/2013 9:25 PM, John Rose wrote:

So getDM has a bug and getM is correct wrt inheritance. Thanks Peter!

More information about the core-libs-dev mailing list