RFR-8008118 (original) (raw)
Christos Zoulas christos at zoulas.com
Wed Apr 10 18:24:46 UTC 2013
- Previous message: RFR-8008118
- Next message: RFR-8008118
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Apr 10, 1:54pm, john.zavgren at oracle.com (John Zavgren) wrote: -- Subject: Re: RFR-8008118
| Your comments are welcome.
- We did we switch from NEW() to xmalloc()? Why is the xmalloc cast needed?
- I would not declare pathv "const char **", but "char **", and then cast the return if needed. This will make life easier in the future if we decide to turn on warnings about const-castaways.
Otherwise LGTM.
christos
- Previous message: RFR-8008118
- Next message: RFR-8008118
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]