RFR: 8004518 & 8010122 : Default methods on Map (original) (raw)
Mike Duigou mike.duigou at oracle.com
Thu Apr 11 05:42:49 UTC 2013
- Previous message: RFR: 8004518 & 8010122 : Default methods on Map
- Next message: RFR: 8004518 & 8010122 : Default methods on Map
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I've posted an updated webrev with the review comments I have received.
http://cr.openjdk.java.net/~mduigou/JDK-8010122/1/webrev/
One important point to consider:
- The current implementations of compute, computeIfPresent, computeIfAbsent, merge are implemented so that they can work correctly for ConcurrentMap instances. For non-concurrent implementations it might be better to fail and throw ConcurrentModification exception whenever concurrent modification is detected. For regular Map implementations the retry behaviour will only serve to mask errors.
Thoughts?
Mike
On Apr 8 2013, at 11:07 , Mike Duigou wrote:
Hello all;
This is a combined review for the new default methods on the java.util.Map interface being added for the JSR-335 lambda libraries. The reviews are being combined because they share a common unit test. http://cr.openjdk.java.net/~mduigou/JDK-8010122/0/webrev/ 8004518: Add in-place operations to Map forEach() replaceAll() 8010122: Add atomic operations to Map getOrDefault() putIfAbsent() * remove(K, V) replace(K, V) replace(K, V, V) compute() * merge() * computeIfAbsent() * computeIfPresent() * The * operations treat null values as being absent. (ie. the same as there being no mapping for the specified key). The default implementations provided in Map are overridden in HashMap for performance purposes, in Hashtable for atomicity and performance purposes and in Collections for atomicity. Mike
- Previous message: RFR: 8004518 & 8010122 : Default methods on Map
- Next message: RFR: 8004518 & 8010122 : Default methods on Map
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]