sun.awt.X11 logs still using String + (waste) (original) (raw)
Mandy Chung mandy.chung at oracle.com
Thu Apr 11 16:11:23 UTC 2013
- Previous message: sun.awt.X11 logs still using String + (waste)
- Next message: sun.awt.X11 logs still using String + (waste)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 4/11/13 9:08 AM, Laurent Bourgès wrote:
Anthony,
Here is the updated webrev: http://jmmc.fr/~bourgesl/share/webrev-8010297.5/ <http://jmmc.fr/%7Ebourgesl/share/webrev-8010297.5/>
Great. Ship it!
Mandy
Laurent 2013/4/11 Mandy Chung <mandy.chung at oracle.com_ _<mailto:mandy.chung at oracle.com>> On 4/11/13 8:43 AM, Laurent Bourgès wrote:
I don't understand if I should fix it or not ? src/solaris/classes/sun/awt/X11/XListPeer.java Nit: line 1906 you remove isLoggable call here. Was it intentional (as it doesn't call concatenate any string?)? I think it's better to use the pattern consistently.
it's a mistake (cookie). Please fix it. Approved and no need to regenerate a new webrev if you fix the above nit. To fix it, I need to send you files as a new webrev ? Anthony is going to sponsor for you and I think he asks for a webrev. So please send the latest webrev with this fix then. Mandy Laurent
- Previous message: sun.awt.X11 logs still using String + (waste)
- Next message: sun.awt.X11 logs still using String + (waste)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]